Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auto-select recommended version for read-only sessions #1683

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

zusorio
Copy link
Member

@zusorio zusorio commented Aug 2, 2024

Fixes #1354

@zusorio zusorio requested a review from MoritzWeber0 as a code owner August 2, 2024 13:40
Copy link

github-actions bot commented Aug 2, 2024

A Storybook preview is available for commit 1212e9c.
View Storybook
View Chromatic build

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.97%. Comparing base (52a41ea) to head (d956401).
Report is 289 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1683   +/-   ##
=======================================
  Coverage   83.97%   83.97%           
=======================================
  Files         184      184           
  Lines        6086     6086           
  Branches      673      673           
=======================================
  Hits         5111     5111           
  Misses        827      827           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zusorio zusorio force-pushed the auto-select-versions-read-only-sessions branch from 37f2cb8 to ef4ef9e Compare August 2, 2024 13:48
@zusorio zusorio changed the title feat: Automatically select the recommended tool version when creating read-only sessions feat: Auto-select recommended version for read-only sessions Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

The pull request does not conform to the conventional commit specification. Please ensure that your commit messages follow the spec: https://www.conventionalcommits.org/.
We also strongly recommend that you set up your development environment with pre-commit, as described in our Developer documentation. This will run all the important checks right before you commit your changes, and avoids lengthy CI wait time and round trips.

This is the commit validation log:

⧗   input: feat: Auto-select recommended version for read-only sessions

This updates the read-only session creator so that it picks the recommended version, should there be one.

Fixes #1354
✖   body's lines must not be longer than 100 characters [body-max-line-length]
✖   footer must have leading blank line [footer-leading-blank]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

Here are some examples of valid commit messages:

build: Bump frontend versions
docs(user): Add model creation workflow
feat: Add a monitoring dashboard

This updates the read-only session creator so that
it picks the recommended version, should there be one.

Fixes #1354
@zusorio zusorio force-pushed the auto-select-versions-read-only-sessions branch from ef4ef9e to d956401 Compare August 2, 2024 13:51
Copy link

sonarqubecloud bot commented Aug 2, 2024

@DSD-DBS DSD-DBS deleted a comment from github-actions bot Aug 2, 2024
Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected in my local environment. Thanks for the implementation! 👍

@MoritzWeber0 MoritzWeber0 merged commit 72a2860 into main Aug 2, 2024
30 checks passed
@MoritzWeber0 MoritzWeber0 deleted the auto-select-versions-read-only-sessions branch August 2, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-select recommended tool version in read-only session request
2 participants